Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADM_flyDialog] add analyzer option #355

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

szlldm
Copy link
Contributor

@szlldm szlldm commented Nov 2, 2021

preliminary analyzer option
main issue is resize
for testing added to "Color balance" filter

@eumagga0x2a
Copy link
Collaborator

Truly amazing, works great on Linux, but FYI, on macOS the analyzer window doesn't stay in foreground when user interacts with the parent filter preview dialog. The special handling of dialogs on macOS in qtRegisterDialog() seems to be redundant now, I'll remove it, but it is not the culprit here, disabling it doesn't help.

On macOS, it is also necessary to manually resize the analyzer window to make sceneVectorScope fit in. When resizing, the background on one or both sides of the graphs is not painted, remains white.

Do you plan to add some guidance for users? Also the size of the graphs is so tiny that while looking very impressive, it is hard to actually make use of the information. Maybe lay out it as a set of tabs?

Apart from this, ahem, I'd suggest renaming flyDialogsAnalyzer member of ADM_flyDialog to avoid attracting ridicule. Yeah, it is the name of the branch :-D

@szlldm
Copy link
Contributor Author

szlldm commented Nov 3, 2021

Its a blind try to fix dialog going into background on macOS.
I have no idea how to fix the other issues.
A will try tabbed layout, or adding checkboxes (also would serves as label).

@eumagga0x2a
Copy link
Collaborator

Its a blind try to fix dialog going into background on macOS.

It hasn't helped, unfortunately.

In general, ordering of modal windows is a mess on macOS. Using Mission Control results in the filter manager dialog becoming the top window above open filter preview while remaining disabled.

I think, targeting 2.8.1+ with this work would remove the pressure to deliver a polished result. It is a pity that we keep releasing from git master rather than a dedicated release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants